Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: Send TRYAGAIN if key not found in MGET request #31038

Open
deveshkandpal1224 opened this issue Nov 24, 2023 · 1 comment
Open

redis: Send TRYAGAIN if key not found in MGET request #31038

deveshkandpal1224 opened this issue Nov 24, 2023 · 1 comment
Labels
area/redis enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@deveshkandpal1224
Copy link
Contributor

deveshkandpal1224 commented Nov 24, 2023

Title: Send TRYAGAIN if key not found in MGET request

Description:

When an MGET request is issued, redis_proxy send GET request on each key and collects the response here.

As per redis cluster spec here , if a hash slot is in migrating state and if any of the keys are not found, the response to the downstream client should be TRYAGAIN.

We run redis_proxy on server side, however it seems this part of the code is common if redis_proxy is executed on client or server side. In this case the redis server needs to respond with TRYAGAIN for the MGET request but today individual GET request prohibits this behavior.

@deveshkandpal1224 deveshkandpal1224 added bug triage Issue requires triage labels Nov 24, 2023
@yanavlasov yanavlasov added area/redis enhancement Feature requests. Not bugs or questions. help wanted Needs help! and removed bug triage Issue requires triage labels Nov 28, 2023
@yanavlasov
Copy link
Contributor

Adding code owners @weisisea @mattklein123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants