Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large request body result in wasm crash #36989

Open
wbpcode opened this issue Nov 5, 2024 · 0 comments · May be fixed by #37079
Open

large request body result in wasm crash #36989

wbpcode opened this issue Nov 5, 2024 · 0 comments · May be fixed by #37079

Comments

@wbpcode
Copy link
Member

wbpcode commented Nov 5, 2024

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged appropriately.

Title: One line description

Description:

#36411 fixed a bug where the wasm filter may cannot get complete request body. But it also introduce another new bug. Given a big request, the addDecodedData() in the decode/encodeData() may trigger the buffer high watermark callback and result in local reply sending (413 payload too large). And after the local reply is sent, the decode/encodeData() will continue run and call into the vm. But because the local reply is sent so the context in vm may has been removed, the calling into vm may finally result in a crash/panic (depends on the sdk implementation).

@wbpcode wbpcode added bug triage Issue requires triage area/wasm and removed triage Issue requires triage labels Nov 5, 2024
@wbpcode wbpcode linked a pull request Nov 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant