Promote the matcher field of the RBAC API to stable #37678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
rbac_matcher_wip
branch
from
c66cac1 to
a6e8785
Compare
zhaohuabing
changed the title
zhaohuabing
changed the title
adisuissa
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I think this is OK, but would like to see if @yanavlasov and @tyxia have a different opinion on making the matchers non-WIP?
|
note: envoy maintainers will be mostly on vacation until 6th jan /wait-any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: promote envoy.extensions.filters.http.rbac.v3.RBAC.matcher from
work_in_progressto stableAdditional Description:
Risk Level: Low
Testing: No
Docs Changes: No
Release Notes: No
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #37677]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]