Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for batch size in metrics service #37777

Open
ramaraochavali opened this issue Dec 20, 2024 · 1 comment
Open

add support for batch size in metrics service #37777

ramaraochavali opened this issue Dec 20, 2024 · 1 comment
Labels
area/grpc area/stats enhancement Feature requests. Not bugs or questions.

Comments

@ramaraochavali
Copy link
Contributor

Currently Metrics Service sends all metrics in a single batch and that causes server side gRPC Message Size (typical 4MB) to trip causing metrics not to be sent. Even if we increase the size, we end up with a catching game. The proposal is to add batch_size defaults to the current behaviour.

@ramaraochavali ramaraochavali added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 20, 2024
@adisuissa adisuissa added area/grpc area/stats and removed triage Issue requires triage labels Dec 20, 2024
@adisuissa
Copy link
Contributor

cc @jmarantz as metrics_service codeowner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc area/stats enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants