Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf regression] 5% increase in user time #3878

Closed
rgs1 opened this issue Jul 17, 2018 · 3 comments
Closed

[perf regression] 5% increase in user time #3878

rgs1 opened this issue Jul 17, 2018 · 3 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements

Comments

@rgs1
Copy link
Member

rgs1 commented Jul 17, 2018

We are seeing a consistent 5% increase in CPU user time between e718500 and 5f8b25e.

From a quick look at commits in between, c92a301 and 45fe83e (less likely) look suspicious.

Currently trying different builds to bisect the change that introduced this.
@rgs1 rgs1 mentioned this issue Jul 17, 2018
Merged
@htuch
Copy link
Member

htuch commented Jul 17, 2018

@rgs1 LMK if it ends up being 45fe83e. Thanks for digging into this.

@rgs1
Copy link
Member Author

rgs1 commented Jul 17, 2018

Looks like it was a false positive, I was (accidentally) comparing a fastbuild build vs an opt build.... I'll circle back tomorrow with more data.

@mattklein123 mattklein123 added the question Questions that are neither investigations, bugs, nor enhancements label Jul 18, 2018
@rgs1
Copy link
Member Author

rgs1 commented Jul 20, 2018

Definitely a false positive, closing.

@rgs1 rgs1 closed this as completed Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Questions that are neither investigations, bugs, nor enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgs1 @mattklein123 @htuch