Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting downstream trailers when upstream has no trailers #3966

Closed
snowp opened this issue Jul 27, 2018 · 1 comment
Closed

Inserting downstream trailers when upstream has no trailers #3966

snowp opened this issue Jul 27, 2018 · 1 comment
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@snowp
Copy link
Contributor

snowp commented Jul 27, 2018

I was playing around with a filter that bridge grpc -> http/1.1 (opposite direction to the bridge that already exists in envoy) and I couldn't figure out how to insert trailers into a downstream h/2 response when the upstream response is h/1.1. It seems like the encodeTrailers cb is not invoked (presumably because the h/1.1 response doesn't have any trailers).

Hopefully I'm missing something and this is already doable. If not, would it be reasonable to add this functionality?

@mattklein123 mattklein123 added question Questions that are neither investigations, bugs, nor enhancements enhancement Feature requests. Not bugs or questions. and removed question Questions that are neither investigations, bugs, nor enhancements labels Jul 27, 2018
@mattklein123
Copy link
Member

Unfortunately I don't think this is possible today. Have a look how addEncodedData() is implemented. We would want to add something similar along the lines of addEncodedTrailers(). I don't think it would be that hard to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants