Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RBAC TCP filter #3993

Closed
yangminzhu opened this issue Jul 31, 2018 · 3 comments
Closed

Add a RBAC TCP filter #3993

yangminzhu opened this issue Jul 31, 2018 · 3 comments
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@yangminzhu
Copy link
Contributor

Title: Add a RBAC TCP filter

Description:
Add a RBAC (Role-Based-Access-Control) TCP filter. This is needed to support authorization for non-HTTP protocol.

Relevant Links:
The RBAC HTTP filter is added in #3455

some open questions:
We could either add a new config proto for the TCP filter that includes fields only available in TCP or just reuse the existing config proto introduced for HTTP filter, and only a subset of the fields are supported in this case.
I prefer the second option but not sure if there is any preference in Envoy when a filter is implemented for both HTTP and TCP.

/cc @liminw @lizan @rodaine @mattklein123

@lizan
Copy link
Member

lizan commented Jul 31, 2018

+1 to reuse existing config proto, which is designed to be generic IIRC (so it wasn't scoped in http package). Of course some of its field (e.g. header matcher) won't be supported in TCP.

@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Jul 31, 2018
@mattklein123
Copy link
Member

+1 to reuse and we can make the HTTP specific things empty. We do this elsewhere in cases like access logging and a few other places.

@liminw
Copy link
Contributor

liminw commented Jul 31, 2018

+1 to reuse. The rbac proto is designed to be generic. Also the rbac engine implementation is designed to be shared for different filter implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

4 participants