You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
Add a RBAC (Role-Based-Access-Control) TCP filter. This is needed to support authorization for non-HTTP protocol.
Relevant Links:
The RBAC HTTP filter is added in #3455
some open questions:
We could either add a new config proto for the TCP filter that includes fields only available in TCP or just reuse the existing config proto introduced for HTTP filter, and only a subset of the fields are supported in this case.
I prefer the second option but not sure if there is any preference in Envoy when a filter is implemented for both HTTP and TCP.
+1 to reuse existing config proto, which is designed to be generic IIRC (so it wasn't scoped in http package). Of course some of its field (e.g. header matcher) won't be supported in TCP.
+1 to reuse. The rbac proto is designed to be generic. Also the rbac engine implementation is designed to be shared for different filter implementations.
Title: Add a RBAC TCP filter
Description:
Add a RBAC (Role-Based-Access-Control) TCP filter. This is needed to support authorization for non-HTTP protocol.
Relevant Links:
The RBAC HTTP filter is added in #3455
some open questions:
We could either add a new config proto for the TCP filter that includes fields only available in TCP or just reuse the existing config proto introduced for HTTP filter, and only a subset of the fields are supported in this case.
I prefer the second option but not sure if there is any preference in Envoy when a filter is implemented for both HTTP and TCP.
/cc @liminw @lizan @rodaine @mattklein123
The text was updated successfully, but these errors were encountered: