Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid v2/v3 static/dynamic configuration; should we support this? #8137

Closed
htuch opened this issue Sep 3, 2019 · 2 comments
Closed

Hybrid v2/v3 static/dynamic configuration; should we support this? #8137

htuch opened this issue Sep 3, 2019 · 2 comments
Assignees
@htuch
Labels
api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue
Milestone
1.13.0

Comments

@htuch
Copy link
Member

htuch commented Sep 3, 2019

A few questions on how to handle hybrid v2/v3 configs for @envoyproxy/api-shepherds:

It's conceivable that an Envoy might have a v3 bootstrap but only be able to ingest dynamic configuration from v2 servers in some operator configuration. Do we want to support these kinds of mixed configurations?

Should we implement fallback support to v2 endpoints if a v3 server is unavailable but configured?

Is this a blocker to v3 release or can we ship with the API pieces in place but no implementation?
@htuch htuch added no stalebot Disables stalebot from closing an issue api/v3 Major version release @ end of Q3 2019 labels Sep 3, 2019
@mattklein123
Copy link
Member

Do we want to support these kinds of mixed configurations?

IMO yes, much like we allowed REST v1 to be called for a while.

Should we implement fallback support to v2 endpoints if a v3 server is unavailable but configured?

IMO we don't need this.

Is this a blocker to v3 release or can we ship with the API pieces in place but no implementation?

IMO we can ship the API without the implementation.

@htuch htuch added this to the 1.13.0 milestone Nov 21, 2019
@htuch htuch self-assigned this Nov 21, 2019
@htuch
Copy link
Member Author

htuch commented Jan 8, 2020

Fixed in #9526

@htuch htuch closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@htuch htuch

Labels
api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
2 participants
@mattklein123 @htuch