-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor outlier detection configuration fields #8219
Comments
Fixed in #8221 |
Oops, I see now that I used the wrong title in this issue, sorry! My understanding based on the linked PR comment was that there's some refactoring of the |
Oh right, sorry, let me reopen and I will add some more detail. |
I updated the issue description a bit to hopefully have a bit more info. |
I think we should create the new outlier config in v2 and then deprecate the existing one, making the v3 bump a mechanical transition. Marking as help wanted, since this needs implementation work. |
Title: Refactor outlier detection config message fields
Description:
As discussed in #8130 (comment), the outlier detection configuration fields are a bit messy and could use a cleanup. The main work here is to de-dup all of the options into a common message around enabled, local origin split, etc. and then hopefully just have a single field per actual ejection type. This would avoid an explosion of almost identical fields for each different ejection type.
The text was updated successfully, but these errors were encountered: