Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor outlier detection configuration fields #8219

Open
csssuf opened this issue Sep 11, 2019 · 5 comments
Open

Refactor outlier detection configuration fields #8219

csssuf opened this issue Sep 11, 2019 · 5 comments
Labels
api/v3 Major version release @ end of Q3 2019 help wanted Needs help!

Comments

@csssuf
Copy link
Contributor

csssuf commented Sep 11, 2019

Title: Refactor outlier detection config message fields

Description:
As discussed in #8130 (comment), the outlier detection configuration fields are a bit messy and could use a cleanup. The main work here is to de-dup all of the options into a common message around enabled, local origin split, etc. and then hopefully just have a single field per actual ejection type. This would avoid an explosion of almost identical fields for each different ejection type.

@mattklein123 mattklein123 added no stalebot Disables stalebot from closing an issue api/v3 Major version release @ end of Q3 2019 labels Sep 11, 2019
@mattklein123 mattklein123 added this to the 1.12.0 milestone Sep 15, 2019
@mattklein123
Copy link
Member

Fixed in #8221

@csssuf
Copy link
Contributor Author

csssuf commented Sep 16, 2019

Oops, I see now that I used the wrong title in this issue, sorry! My understanding based on the linked PR comment was that there's some refactoring of the OutlierDetection message itself that's desired; #8221 was more of a mechanical fix.

@mattklein123
Copy link
Member

Oh right, sorry, let me reopen and I will add some more detail.

@mattklein123 mattklein123 reopened this Sep 16, 2019
@mattklein123
Copy link
Member

I updated the issue description a bit to hopefully have a bit more info.

@htuch
Copy link
Member

htuch commented Sep 26, 2019

I think we should create the new outlier config in v2 and then deprecate the existing one, making the v3 bump a mechanical transition. Marking as help wanted, since this needs implementation work.

@htuch htuch added the help wanted Needs help! label Sep 26, 2019
@htuch htuch removed this from the 1.12.0 milestone Sep 27, 2019
@mattklein123 mattklein123 removed the no stalebot Disables stalebot from closing an issue label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v3 Major version release @ end of Q3 2019 help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

3 participants