[balsa] Verify URL. #22040
Merged
[balsa] Verify URL. #22040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Http1ServerConnectionImplTest.Http11InvalidRequest, and adds extensive testing to the URL validator that both http-parser and the new isUrlValid in BalsaParser pass. Tested by patching in #22039 and running bazel test //test/common/http/http1:codec_impl_test --test_arg=--runtime-feature-override-for-tests=envoy.reloadable_features.http1_use_balsa_parser Tracking issue: #21245 Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
|
/assign @yanavlasov |
diannahu
previously approved these changes
Jul 8, 2022
Signed-off-by: Bence Béky <bnc@google.com>
diannahu
previously approved these changes
Jul 8, 2022
yanavlasov
previously approved these changes
Jul 12, 2022
|
@bencebeky needs merge and fixing merge conflicts. |
|
/wait |
Signed-off-by: Bence Béky <bnc@google.com>
|
Thank you for the review. I resolved the merge conflicts, and all checks have passed. This PR seems to be ready to be merged. |
|
Ping @wrowe. Thank you. |
yanavlasov
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Http1ServerConnectionImplTest.Http11InvalidRequest, and adds
extensive testing to the URL validator that both http-parser and the new
isUrlValid in BalsaParser pass.
Tested by patching in #22039 and running
bazel test //test/common/http/http1:codec_impl_test
--test_arg=--runtime-feature-override-for-tests=envoy.reloadable_features.http1_use_balsa_parser
Tracking issue: #21245
Signed-off-by: Bence Béky bnc@google.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]