Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add mergeGateways field to EnvoyProxy spec #1289

Merged
merged 3 commits into from
Sep 26, 2023
Merged

api: add mergeGateways field to EnvoyProxy spec #1289

merged 3 commits into from
Sep 26, 2023

Conversation

cnvergence
Copy link
Member

Extend API to provide a way to merge gateways

See also:

@cnvergence cnvergence force-pushed the api-merge-gateways branch 2 times, most recently from 6c9947d to 5fa9e88 Compare April 11, 2023 16:31
@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Merging #1289 (b1c16f4) into main (67b885d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          88       88           
  Lines       13031    13031           
=======================================
+ Hits         8512     8513    +1     
+ Misses       3991     3990    -1     
  Partials      528      528

see 2 files with indirect coverage changes

@cnvergence cnvergence marked this pull request as ready for review April 11, 2023 16:40
@cnvergence cnvergence requested a review from a team as a code owner April 11, 2023 16:40
@arkodg arkodg added this to the 0.5.0-rc1 milestone Apr 11, 2023
@cnvergence cnvergence force-pushed the api-merge-gateways branch 3 times, most recently from b0622d3 to 7cc609d Compare April 12, 2023 07:52
@arkodg
Copy link
Contributor

arkodg commented Apr 12, 2023

hey @cnvergence thanks for raising this PR, lets wait a bit to see if upstream plans on introducing a native API for this in v0.8.0, else we can continue with this approach.

@cnvergence
Copy link
Member Author

sure @arkodg, let's put it on hold for now then

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label May 13, 2023
@kflynn kflynn modified the milestones: 0.5.0-rc1, Backlog Jun 13, 2023
@github-actions github-actions bot removed the stale label Jun 14, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 14, 2023
cnvergence and others added 2 commits September 25, 2023 14:41
@cnvergence
Add mergeGateways field to EnvoyProxy spec
5f4cba0 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence @arkodg
Update api/config/v1alpha1/envoyproxy_types.go
2eedb42 
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence force-pushed the api-merge-gateways branch 2 times, most recently from d0061fc to 9121ef9 Compare September 25, 2023 12:46
@cnvergence
Fix dot
b1c16f4 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
Copy link
Member Author

/retest

@cnvergence
Copy link
Member Author

@arkodg PTAL once again

@github-actions github-actions bot removed the stale label Sep 25, 2023
arkodg
arkodg approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, kflynn, LanceEa and chauhanshubham and removed request for a team September 25, 2023 17:04
@Alice-Lilith Alice-Lilith merged commit c70144b into envoyproxy:main Sep 26, 2023
20 checks passed
@cnvergence cnvergence deleted the api-merge-gateways branch September 27, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alice-Lilith Alice-Lilith Alice-Lilith approved these changes

@arkodg arkodg arkodg approved these changes

@kflynn kflynn Awaiting requested review from kflynn kflynn was automatically assigned from envoyproxy/gateway-reviewers

@LanceEa LanceEa Awaiting requested review from LanceEa LanceEa was automatically assigned from envoyproxy/gateway-reviewers

@chauhanshubham chauhanshubham Awaiting requested review from chauhanshubham chauhanshubham was automatically assigned from envoyproxy/gateway-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@cnvergence @arkodg @Alice-Lilith @kflynn