Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return 500's for invalid HTTPRoute backend refs #162

Closed
skriss opened this issue Jul 15, 2022 · 3 comments · Fixed by #443
Closed

return 500's for invalid HTTPRoute backend refs #162

skriss opened this issue Jul 15, 2022 · 3 comments · Fixed by #443
Assignees
@Alice-Lilith
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. help wanted Extra attention is needed kind/enhancement New feature or request
Milestone
0.2.0-rc2

Comments

@skriss
Copy link
Contributor

skriss commented Jul 15, 2022

There is a set of rules around how to handle 1+ invalid backend refs on an HTTPRoute that generally involve returning 500 responses for any invalid backends. This needs to be implemented properly.

https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPRouteRule (see backendRefs).

Needed for core conformance.
@skriss skriss added the kind/enhancement New feature or request label Jul 15, 2022
@skriss skriss added this to the 0.2.0-rc1 milestone Jul 15, 2022
@skriss skriss changed the title return 500's for invalid backend refs return 500's for invalid HTTPRoute backend refs Jul 15, 2022
@skriss skriss added the help wanted Extra attention is needed label Jul 15, 2022
@skriss skriss added the area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. label Aug 4, 2022
@danehans danehans modified the milestones: 0.2.0-rc1, 0.2.0-rc2 Aug 30, 2022
@skriss skriss mentioned this issue Sep 6, 2022
Closed
@Alice-Lilith
Copy link
Member

I'll take this issue

@danehans
Copy link
Contributor

@AliceProxy FYI I'm seeing this issue with the following conformance tests:

#431
#432
#433

Please see these issues for additional details.

@Alice-Lilith
Copy link
Member

@AliceProxy FYI I'm seeing this issue with the following conformance tests:

#431 #432 #433

Please see these issues for additional details.

👍 The changes I was working on at the end of last week didn't properly handle the weighted responses so I switched over to a solution similar to how Istio is doing it. I'm trying to get a PR up for the gateway meeting in a few hours, but I'll keep working on this until it's done either way today.

@Alice-Lilith Alice-Lilith mentioned this issue Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alice-Lilith Alice-Lilith

Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Milestone
0.2.0-rc2
Development

Successfully merging a pull request may close this issue.

Return 500 responses for invalid backends
3 participants
@danehans @skriss @Alice-Lilith