Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support retries #1907

Closed
arkodg opened this issue Sep 26, 2023 · 7 comments · Fixed by #2678
Closed

Support retries #1907

arkodg opened this issue Sep 26, 2023 · 7 comments · Fixed by #2678
Assignees
@tmsnan @guydc
Labels
area/api API-related issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. kind/enhancement New feature or request road-to-ga
Milestone
v1.0.0-rc1

Comments

@arkodg
Copy link
Contributor

arkodg commented Sep 26, 2023

Description:

Add retry settings to be able to retry making requests to a backend

Relates to

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@arkodg arkodg added the kind/enhancement New feature or request label Sep 26, 2023
@arkodg arkodg added this to the Backlog milestone Sep 26, 2023
@arkodg arkodg added area/api API-related issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. labels Sep 26, 2023
@zirain
Copy link
Member

zirain commented Sep 26, 2023

need something like TimeoutPolicy on upstream?

@arkodg
Copy link
Contributor Author

arkodg commented Sep 26, 2023

@zirain, based on @kflynn's comment here we should try and implement in this project as a top level field within BackendTrafficPolicy

@zirain
Copy link
Member

zirain commented Sep 26, 2023

oh, may bad, there's only one client(the proxy) in ingress mode.
yes, we can put retries under BackendTrafficPolicy .

@arkodg arkodg added the help wanted Extra attention is needed label Oct 3, 2023
@arkodg arkodg modified the milestones: Backlog, 0.6.0-rc1 Oct 3, 2023
@arkodg arkodg modified the milestones: 0.6.0-rc1, Backlog Oct 18, 2023
@tmsnan
Copy link
Contributor

tmsnan commented Oct 25, 2023

/assign

@zirain zirain removed the help wanted Extra attention is needed label Oct 25, 2023
@tmsnan tmsnan mentioned this issue Nov 9, 2023
Closed
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Nov 24, 2023
@Xunzhuo Xunzhuo modified the milestones: Backlog, v1.0.0-rc1 Dec 7, 2023
@Xunzhuo Xunzhuo moved this from Todo to In Progress in Envoy Gateway: The Road to GA Dec 7, 2023
@github-actions github-actions bot removed the stale label Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jan 6, 2024
@arkodg arkodg removed the stale label Jan 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Feb 8, 2024
@arkodg arkodg removed the stale label Feb 8, 2024
@guydc guydc mentioned this issue Feb 20, 2024
Merged
@guydc guydc self-assigned this Feb 21, 2024
@guydc guydc mentioned this issue Feb 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Envoy Gateway: The Road to GA Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmsnan tmsnan

@guydc guydc

Labels
area/api API-related issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. kind/enhancement New feature or request road-to-ga
Projects
No open projects
Envoy Gateway: The Road to GA
Status: Done
Milestone
v1.0.0-rc1
Development

Successfully merging a pull request may close this issue.

feat(translator): Implement Retry in BTP guydc/gateway
5 participants
@zirain @arkodg @tmsnan @guydc @Xunzhuo