Enable GatewayHTTPListenerIsolation conformance test

[arkodg]

Description:

Describe the issue.

Details of the test are in kubernetes-sigs/gateway-api#3047

Remove from https://github.com/envoyproxy/gateway/blob/0457ee7417288159eaa4422ee243b808a1696604/test/conformance/experimental_conformance_test.go#L33C3-L33C47 once fixed

[optional Relevant Links:]

Any extra documentation required to understand the issue.

[levikobi]

Hi @arkodg, I would like to try taking on this one if that's ok.
If there's anything important/helpful I should know about before diving in, please let me know

[shawnh2]

Thanks @levikobi for picking this one up!

[arkodg]

thanks for picking this one up @levikobi ! feel free to comment on the issue here with what you are seeing fail in the test, and can link you to the relevant code that may need to be revisited

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

[arkodg]

hey @levikobi stil working on this one ? its would be great if we could get this into v1.1

[levikobi]

Hi @arkodg, sorry for the delay. I have been pretty busy lately.
Yes, I would like to work on this one. I'll keep you updated throughout this week.
When is v1.1 supposed to come out?

[levikobi]

Hi @arkodg
I run GatewayHTTPListenerIsolation conformance test, and the following cases fail, as their requests receive a 404 response:

• 0_request_to_'bar.com/empty-hostname'_should_go_to_infra-backend-v1
• 5_request_to_'bar.example.com/wildcard-example-com'_should_go_to_infra-backend-v1
• 10_request_to_'bar.foo.example.com/wildcard-foo-example-com'_should_go_to_infra-backend-v1
• 15_request_to_'abc.foo.example.com/abc-foo-example-com'_should_go_to_infra-backend-v1

The other cases are passing since they expect a 404 response.

I looked at the proxy instance and saw this log:

[2024-07-28 05:01:00.536][1][warning][config] [source/extensions/config_subscription/grpc/delta_subscription_state.cc:269] delta config for type.googleapis.com/envoy.config.route.v3.RouteConfiguration rejected: Only unique values for domains are permitted. Duplicate entry of domain *.example.com in route gateway-conformance-infra/http-listener-isolation-with-hostname-intersection/empty-hostname
[2024-07-28 05:01:00.536][1][warning][config] [source/extensions/config_subscription/grpc/grpc_subscription_impl.cc:138] gRPC config for type.googleapis.com/envoy.config.route.v3.RouteConfiguration rejected: Only unique values for domains are permitted. Duplicate entry of domain *.example.com in route gateway-conformance-infra/http-listener-isolation-with-hostname-intersection/empty-hostname

To my understanding, and please correct me if I'm wrong - the fix should be at the translation logic at internal/gatewayapi/translator.go?

[arkodg]

thanks for digging into this @levikobi
relevant logic lives in

gateway/internal/gatewayapi/route.go

Line 654 in 87909aa

hosts := computeHosts(GetHostnames(route), listener.Hostname)

and

gateway/internal/xds/translator/translator.go

Line 394 in 87909aa

// 1:1 between IR HTTPRoute Hostname and xDS VirtualHost.

you can even convert the filing sub tests into unit tests by adding input test files in https://github.com/envoyproxy/gateway/tree/main/internal/gatewayapi/testdata and running make testdata and looking at the o/p file to decipher if its what we expect or not

[levikobi]

Thanks for the help @arkodg!
I managed to make the conformance tests pass and created a PR. However, It's still a draft since I want to add some more tests around the new code.
Please feel free to take a look though