envoy-gateway support multi content-type

[qicz]

support core types by protobuf and envoy-gateway apis by json

[zirain]

does GatewayAPI support protobuf?

[qicz]

does GatewayAPI support protobuf?

raised PR kubernetes-sigs/gateway-api#3346

[zirain]

I didn't found too much docs for this, how can we achieve this?

[qicz]

https://kubernetes.io/docs/reference/using-api/api-concepts/#alternate-representations-of-resources @zirain

[qicz]

kubernetes/client-go#76

[zirain]

https://kubernetes.io/docs/reference/using-api/api-concepts/#alternate-representations-of-resources @zirain

I'm asking how to make our api support it? does EG need any code change?

[qicz]

https://kubernetes.io/docs/reference/using-api/api-concepts/#alternate-representations-of-resources @zirain

I'm asking how to make our api support it? does EG need any code change?

add protobuf tag in API struct

[zirain]

https://kubernetes.io/docs/reference/using-api/api-concepts/#alternate-representations-of-resources @zirain

I'm asking how to make our api support it? does EG need any code change?

add protobuf tag in API struct

can you share an existing project that do such things as demo.

[qicz]

https://kubernetes.io/docs/reference/using-api/api-concepts/#alternate-representations-of-resources @zirain

I'm asking how to make our api support it? does EG need any code change?

add protobuf tag in API struct

can you share an existing project that do such things as demo.

client-go and go-controller-panel have more places using protobuf

https://github.com/kubernetes/apimachinery/blob/c98a9e22228d62689a77506ca0252d70f703958b/pkg/apis/meta/v1/types.go#L111-L152

https://github.com/envoyproxy/go-control-plane/blob/ec6977db26e1e30f8fc353a90442112a7f2b00d6/envoy/api/v2/listener.pb.go#L83-L127

[zirain]

go-control-plane generated from proto to go struct, so I thinks that's not valid example?

for client-go, I cannot find the tag protobuf you said.

[liorokman]

In order for the API server to be able to decode protobuf-encoded resources, the protobuf definitions need to be compiled into the API server.

In Kubernetes, sending the API server protobuf encoded resources only works for core resources, and not for CRDs.

As written here:

Not all API resource types support Protobuf; specifically, Protobuf isn't available for resources that are defined as CustomResourceDefinitions or are served via the aggregation layer.

[qicz]

In order for the API server to be able to decode protobuf-encoded resources, the protobuf definitions need to be compiled into the API server.

In Kubernetes, sending the API server protobuf encoded resources only works for core resources, and not for CRDs.

As written here:

Not all API resource types support Protobuf; specifically, Protobuf isn't available for resources that are defined as CustomResourceDefinitions or are served via the aggregation layer.

yep, just core types support protobuf. kubernetes/kubernetes#55541

we can support core types by protobuf and crd by json with two client instances. Any other suggestions?

cc @zirain

[zirain]

we can support core types by protobuf and crd by json with two client instances

sgtm

[liorokman]

we can support core types by protobuf and crd by json with two client instances. Any other suggestions?

cc @zirain

Controller-runtime based clients already uses protobuf for types that support it.

See kubernetes-sigs/controller-runtime#1149

[qicz]

we can support core types by protobuf and crd by json with two client instances. Any other suggestions?
cc @zirain

Controller-runtime based clients already uses protobuf for types that support it.

See kubernetes-sigs/controller-runtime#1149

Great, we should refactor clients using the informer. but the controller will refactor too, I think that is impossible, there are too many dependencies.

[liorokman]

Great, we should refactor clients using the informer. but the controller will refactor too, I think that is impossible, there are too many dependencies.

I can't find places in the codebase where a non controller-runtime client is used. Can you provide a link to code that needs to be fixed? The code in internal/provider/kubernetes uses controller-runtime to get clients to the provider, as far as I can tell.

[qicz]

already support multi content-type