Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitenoise linter is broken #5255

Open
shahar-h opened this issue Feb 11, 2025 · 1 comment
Open

whitenoise linter is broken #5255

shahar-h opened this issue Feb 11, 2025 · 1 comment
Labels
triage

Comments

@shahar-h
Copy link
Contributor

Description:

fatal: ambiguous argument 'origin/': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

https://github.com/envoyproxy/gateway/actions/runs/13255867578/job/37002537258

From looking at the code $GITHUB_BASE_REF is not populated:
https://github.com/envoyproxy/gateway/blob/c4920899659e75ceb342df02665e1b484eb0ecbc/tools/src/whitenoise.sh#L5C74-L5C89
@zirain
Copy link
Member

zirain commented Feb 11, 2025

TBH, I've never successfully run this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zirain @shahar-h