Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

counter-based termination conditions may get slightly exceeded #356

Open
oschaaf opened this issue Jun 11, 2020 · 0 comments
Open

counter-based termination conditions may get slightly exceeded #356

oschaaf opened this issue Jun 11, 2020 · 0 comments

Comments

@oschaaf
Copy link
Member

oschaaf commented Jun 11, 2020

Consider a configured threshold as follows:

--termination-predicate benchmark.http_2xx:99

The way this is implemented, when the client stops, one would expect to see benchmark.http_2xx at 100 when the client finishes.

However, it looks like it is possible under certain conditions to have Nighthawk report a slightly higher number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oschaaf