-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shallow renderer never call componentDidUpdate in v16. #1058
Comments
We do not support alphas or betas of React. When we do support it, we'll have to adapt to this behavior, but it'll be adapter-specific. See #1007. |
Yeah, I don't mean enzyme should support React alphas or betas, which is just to report what enzyme should resolve until v3. BTW, Does enzyme have a plan to support React RCs? |
I've just encountered this with the released version, should this be reopened? |
🤔 It's still not working for me, not sure why, I'll try to isolate the use-case. |
In React 16, the shallow renderer is not supposed to call cDU. That's what those PRs address. |
Shallow render no longer call componentDidUpdate from
16.0.0-beta.3
.facebook/react#10372
Currently, enzyme's shallow calls cDU manually when calling
setProps
withlifecycleExperimental
flag.By this change, we need to call cDU manually even if
setState
is called withlifecycleExperimental
flag.But enzyme has a plan that
lifecycleExperimental
is default in v3.In the case, we need to always call cDU except
disableLifecycleMethods
is true.I can work on this, but it will be based on this PR.
The text was updated successfully, but these errors were encountered: