Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if context supplied without corresponding childContextTypes #1327

Closed
WickyNilliams opened this issue Nov 6, 2017 · 2 comments
Closed

Comments

@WickyNilliams
Copy link

WickyNilliams commented Nov 6, 2017

I think it would be useful to warn/error if context option is supplied without corresponding childContextTypes option (and possibly vice versa, though i imagine that's far less likely to occur).

In the last few days, a teammate of mine and someone on reactiflux have both made the mistake of omitting childContextTypes. So it seems like an obvious place to guide developers in the right direction.

@ljharb
Copy link
Member

ljharb commented Nov 6, 2017

Related to #664.

@ljharb
Copy link
Member

ljharb commented Feb 26, 2019

Now that #664 is merged, if you fail to provide childContextTypes, then children simply won't get your context - so this should no longer require a warning.

@ljharb ljharb closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants