Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization of TimePointSec value is invalid. #153

Closed
keisuke-kanao opened this issue Apr 23, 2021 · 2 comments
Closed

Serialization of TimePointSec value is invalid. #153

keisuke-kanao opened this issue Apr 23, 2021 · 2 comments

Comments

@keisuke-kanao
Copy link

TimePointSec is of type uint32 so I think below line shold be modified such that it writes a uint32 value.
https://github.com/eoscanada/eos-go/blob/develop/encoder.go#L173
@maoueh
Copy link
Contributor

maoueh commented Apr 23, 2021

Yep your are right: https://github.com/EOSIO/fc/blob/ff56d25e587f8131cfde06f1eb61baa899bc8a89/include/fc/time.hpp#L121.

Feel free to propose a PR. Otherwise, we will fix this when we got some time in the upcoming weeks.

@keisuke-kanao keisuke-kanao mentioned this issue Apr 24, 2021
Merged
@maoueh
Copy link
Contributor

maoueh commented Apr 24, 2021

Fixed by #154

@maoueh maoueh closed this as completed Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maoueh @keisuke-kanao