Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): avoid unneded use of useEffect #788

Merged
merged 1 commit into from
May 19, 2022
Merged

fix(webapp): avoid unneded use of useEffect #788

merged 1 commit into from
May 19, 2022

Conversation

leisterfrancisco
Copy link
Collaborator

Improve the create and send tokens flow

What does this PR do?

  • Resolve frozen page after new account creation

Steps to test

  1. run the command make run
  2. create a new account /faucet
  3. send tokens /faucet

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@leisterfrancisco leisterfrancisco self-assigned this May 19, 2022
@xavier506 xavier506 merged commit 43102e6 into dev May 19, 2022
@xavier506 xavier506 deleted the fix/frozen-account-creator branch May 19, 2022 03:56
tetogomez
tetogomez reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@tetogomez tetogomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetogomez tetogomez tetogomez left review comments

@xavier506 xavier506 Awaiting requested review from xavier506

@AngeloCG97 AngeloCG97 Awaiting requested review from AngeloCG97

Assignees

@leisterfrancisco leisterfrancisco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leisterfrancisco @tetogomez @xavier506