Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): updated webapp and hapi dependencies #843

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

fvives99
Copy link
Contributor

@fvives99 fvives99 commented Aug 4, 2022

Update nodeJS dependencies

What does this PR do?

Steps to test

  1. see package.json on hapi and webapp

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@fvives99 fvives99 requested a review from xavier506 August 4, 2022 23:39
@fvives99 fvives99 linked an issue Aug 4, 2022 that may be closed by this pull request
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we verified there are no breaking changes with this update?

@fvives99
Copy link
Contributor Author

fvives99 commented Aug 9, 2022

Have we verified there are no breaking changes with this update?

image

Here's a picture of jungle testnet running locally with the hapi and webapp dependencies updated.

In order to make it possible to run locally, some lines must be commented on the makefile due to an ongoing issue with the dashboard wallet:

	make start-postgres
# make start-wallet
	make start-hapi
	make start-hasura
	make -j 3 start-hasura-cli start-logs start-webapp

start-postgres:
	@docker-compose up -d --build postgres

# start-wallet:
# 	@docker-compose up -d --build wallet`

@fvives99 fvives99 requested a review from xavier506 August 9, 2022 22:04
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 0383a48 into dev Aug 23, 2022
@xavier506 xavier506 deleted the 775-update-nodejs-dependecies branch August 23, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nodeJS dependecies
2 participants