Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): temporary fix for testnets #915 #919

Merged
merged 3 commits into from
Sep 24, 2022
Merged

fix(webapp): temporary fix for testnets #915 #919

merged 3 commits into from
Sep 24, 2022

Conversation

fvives99
Copy link
Contributor

@fvives99 fvives99 commented Sep 23, 2022 •
edited
Loading

What does this PR do?

Steps to test

  1. Copy telos, wax or proton .env testnets and run locally

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@fvives99 fvives99 linked an issue Sep 23, 2022 that may be closed by this pull request
Testnets don't work #915
Closed
Torresmorah
Torresmorah approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@Torresmorah Torresmorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xavier506
xavier506 requested changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvives99 are you sure you updated all the endpoints i believe they are also set for hapi service

@fvives99
Copy link
Contributor Author

@fvives99 are you sure you updated all the endpoints i believe they are also set for hapi service

If im not mistaken, this commit does that, if not ill re verify

@xavier506 xavier506 merged commit 19bd8e3 into dev Sep 24, 2022
@xavier506 xavier506 deleted the 915-testnets-dont-work branch September 24, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 requested changes

@Torresmorah Torresmorah Torresmorah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testnets don't work
3 participants
@fvives99 @xavier506 @Torresmorah