Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/endpoints bug pagination #931

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Feat/endpoints bug pagination #931

merged 7 commits into from
Sep 28, 2022

Conversation

Torresmorah
Copy link
Collaborator

@Torresmorah Torresmorah commented Sep 27, 2022 •
edited
Loading

Endpoints bug pagination

What does this PR do?

  • Resolve Pagination is broken #927
  • Use Sets when endpoints are saved to avoid duplication
  • Remove box and grid from endpointsList component
  • Split State from endpointsList component
  • Split EndpointTable component from endpointsList component

Steps to test

  1. Run the project locally
  2. Go to endpoints page
  3. Check the pagination

Screenshots

imagen

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@Torresmorah Torresmorah self-assigned this Sep 27, 2022
@Torresmorah Torresmorah linked an issue Sep 27, 2022 that may be closed by this pull request
Rest API to list node endpoints #703
Closed
2 tasks
fvives99
fvives99 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@fvives99 fvives99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xavier506
xavier506 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 8152795 into dev Sep 28, 2022
@xavier506 xavier506 deleted the feat/api-endpoints-703 branch September 28, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@fvives99 fvives99 fvives99 approved these changes

@leisterfrancisco leisterfrancisco Awaiting requested review from leisterfrancisco

@tetogomez tetogomez Awaiting requested review from tetogomez

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination is broken Rest API to list node endpoints
4 participants
@Torresmorah @xavier506 @fvives99 @code-factor