Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]windows can't read the Milvus url config #1785

Closed
6 of 15 tasks
shaoqing404 opened this issue Aug 7, 2024 · 4 comments
Closed
6 of 15 tasks

[Bug]windows can't read the Milvus url config #1785

shaoqing404 opened this issue Aug 7, 2024 · 4 comments
Labels
bug Something isn't working stale Waiting for reply

Comments

@shaoqing404
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

Operating system information

Windows

Python version information

=3.11

DB-GPT version

latest release

Related scenes

  • Chat Data
  • Chat Excel
  • Chat DB
  • Chat Knowledge
  • Model Management
  • Dashboard
  • Plugins

Installation Information

Device information

7754HX 笔记本版本cpu
4070 笔记本版本

Models information

deepseek+glm-4-0520+bge_embedding

What happened

VECTOR_STORE_TYPE=Chroma 后,window 不读取配置文件中的 MILVIS、TuGrah配置。当前版本似乎将VECTOR_STORE_TYPE和Graph定义成唯一组件,但在实际应用中会依赖同一个目的下的不同组件。
配置文件如下,已经完成了隐私控制:

`VECTOR_STORE_TYPE=Chroma
GRAPH_STORE_TYPE=TuGraph

Chroma vector db config

#CHROMA_PERSIST_PATH=/root/DB-GPT/pilot/data

Milvus vector db config

#VECTOR_STORE_TYPE=Milvus
MILVUS_URL=10.108..
MILVUS_PORT=19530
MILVUS_USERNAME=wintelia
MILVUS_PASSWORD=wintelia2024
MILVUS_SECURE=False

Weaviate vector db config

#VECTOR_STORE_TYPE=Weaviate
#WEAVIATE_URL=https://kt-region-m8hcy0wc.weaviate.network

## ElasticSearch vector db config

#VECTOR_STORE_TYPE=ElasticSearch
ElasticSearch_URL=10.108..
ElasticSearch_PORT=9200
ElasticSearch_USERNAME
EicSearchlast_PASSWORD

TuGraph config

TUGRAPH_HOST=10.108.4.1
TUGRAPH_PORT=33314
TUGRAPH_USERNAME=admin
TUGRAPH_PASSWORD=73@TuGraph
TUGRAPH_VERTEX_TYPE=entity
TUGRAPH_EDGE_TYPE=relation
TUGRAPH_EDGE_NAME_KEY=label

##
#** WebServer Language Support **#
#
#

en, zh, fr, ja, ko, ru

#LANGUAGE=en
LANGUAGE=zh`

What you expected to happen

dbgpt.storage.vector_store.milvus_store中 class MilvusStore 在被上层调用了采用了默认的 MilvusVectorConfig 配置(当VECTOR_STORE_TYPE 被指向非Milvus时)。这导致配置文件在期望使用多个 VECTOR_STORE 时出现错误。

在该版本中,同样的情况出现在Graphrag上,由于对.env配置文件读取的异常,同时采用同类型多个服务组件变得困难。

期望官方调整.env的读取方式,对于proxy_llm 以列表方式读取,运行在online的llm下初始化时运行多个模型,载入多个不同组件的Vector_store和graph作为备选。

我正在将Graphrag作为服务整合进入dbgpt,但由于配置读取上设计思路的复杂化导致直接嵌入几乎不可取。

How to reproduce

windows 11 下配置 ### TuGraph config #VECTOR_STORE_TYPE=ElasticSearch ### Weaviate vector db config 和#VECTOR_STORE_TYPE=Milvus 即可复现

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@shaoqing404 shaoqing404 added bug Something isn't working Waiting for reply labels Aug 7, 2024
@shaoqing404
Copy link
Author

一个临时的解决方案能够让配置生效:
修改dbgpt.storage.vector_store.milvus_store.MilvusStore 中(大约在164行)所有关于milvus的配置判断,先判断os.getenv下的配置信息,再从 milvus_vector_config = vector_store_config.to_dict() 中读取。

在测试中,大多数情况下milvus组件的配置都默认指向了localhost,这是不对的。

@Aries-ckt
Copy link
Collaborator

@shaoqing404, sorry about that, we will update milvus url config localhost

@Aries-ckt Aries-ckt changed the title windows下Miluvs配置不读取问题 [Bug]windows can't read the Milvus url config Aug 9, 2024
Copy link

github-actions bot commented Sep 8, 2024

This issue has been marked as stale, because it has been over 30 days without any activity.

@github-actions github-actions bot added the stale label Sep 8, 2024
Copy link

This issue bas been closed, because it has been marked as stale and there has been no activity for over 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Waiting for reply
Projects
None yet
Development

No branches or pull requests

2 participants