Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of eslint 9.x #705

Open
bloom-alex opened this issue Jul 4, 2024 · 3 comments
Open

Support of eslint 9.x #705

bloom-alex opened this issue Jul 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@bloom-alex
Copy link

Is your feature request related to a problem? Please describe.

Hello, any plans of supporting eslint 9.x?

Describe the solution you'd like

Currently in the process of migrating to eslint 9.x and from what I can tell, the rule works just fine as is. Did a few manual tests trying to see if it would lead to false positives or false negatives and it's been behaving as expected.

@Elindorath
Copy link

Sadly, there seems to be issues with ESLint v9: this version introduced some changes in the rule API, notably methods of the context object (that this plugin uses) were moved to the sourceCode object (see this troubleshooting page). We can make the current plugin version work by wrapping it with the fixupPluginRules method from @eslint/compat though.

A quick search on the repository seems to indicate there is only one change to make in src/rules/named-export.ts.

@axten
Copy link

axten commented Nov 4, 2024

Hello!
sadly, this is the last plugin that is stopping us from upgrading to eslint 9.
Did you make any progress on fixing the issue?
Thx for you work!

@axten
Copy link

axten commented Nov 5, 2024

I also tested the plugin with eslint 9 without any issues.
so maybe we can just update the peer dependencies for eslint 9 in a first PR and see if more people get affected by potentially bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants