Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated code has lint errors #221

Closed
guymclean opened this issue Aug 24, 2021 · 2 comments · Fixed by #222
Closed

Generated code has lint errors #221

guymclean opened this issue Aug 24, 2021 · 2 comments · Fixed by #222

Comments

@guymclean
Copy link

In version 2.0.4 you "Added equals override method to all Models" which allows us to unit test our code, thanks! Newer versions of Dart specify you must also override 'hashCode' when overriding '=='. As part of our CI pipelines we run 'dart fix' which automatically fixes issues like this one. This now means that each time we run build runner, the generated code reverts to having these lint issues highlighted. Would it be possible to also override 'hashCode' as well as '=='?

@Vovanella95
Copy link
Collaborator

Hi @guymclean ,

We will generate getHashCode override too. Thanks for raising this issue.

@Vovanella95
Copy link
Collaborator

Hi again.
Please check v 2.1.0-prerelease.8

@guymclean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants