-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position single elements and reactions, not included to the first cascade reaction #2102
Comments
Exploratory testing is completed on RC Remote env:
The feature includes different cases for loading from RDF (single reactions, cascade reactions), checks below are covered, tests are updated:
Detected and fixed defects: But there are some failed manual tests based on detected defects and the main scenario should be retested after fixes in the nearest releases 1.25.0-rc.2, 1.26.0-rc.1:
This issue is added to refined backlog and will be fixed later: Also, some unrelated issues were detected during exploratory testing: |
New defects related to length of arrows are detected: |
As a User, I want any reactions or elements in the RDF file that are not included in the reaction tree to be placed below the reaction tree on the canvas, so that I can view all the data from the RDF file in a structured and organized manner.
Acceptance Criteria:
The application should identify any reactions or elements in the loaded RDF file that are not included in the reaction tree.
Reactants and products without match should be understand as a separate reactions.
These identified reactions or elements should be placed on the canvas below the reaction tree. They should not overlap with the reaction tree or with each other.
Reactions not included to a pathway reaction, should be displayed as separate multi-tail reactions.
Reactions with more than one product can be a part of pathway reaction if the match happens, they will be displayed without pluses, otherwise reactions will be displayed as separate ones with a multi-tail arrow when we have several reactants and with a single arrow when we have 1 reactant
TBD: Molecule with atoms that are placed on the same position can be loaded as reactants or products in pathway reaction - issues with existing behavior, defects are reported - "Convert error! metalayout: average bond length is too small" error appears when loading from RDF and RXN V2000/V3000 reactions with molecules with 0 coordinates #2431, Molecule with 0 coordinates in MOL V2000 is displayed incorrectly on Canvas after loading #2432
Reagents should be ignored (TBD - create a task for case where reagents can be recognized)
In case of empty RDF (no reactions, reactants or products), nothing should be added to the canvas.
In cases of one reactant or one product in pathway reaction, it should works as for single arrow in RXN
RDF file can be recognized if there are reactions, RDF file with molecules only can't be recognized - error is displayed
After loading from the RDF file, the ordering of separate cascade reactions on Canvas should be the same as in the RDF file
The text was updated successfully, but these errors were encountered: