Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position single elements and reactions, not included to the first cascade reaction #2102

Closed
yauhen-karmyzau opened this issue Jul 8, 2024 · 2 comments · Fixed by #2295
Closed
Assignees
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue

Comments

@yauhen-karmyzau
Copy link
Collaborator

yauhen-karmyzau commented Jul 8, 2024

As a User, I want any reactions or elements in the RDF file that are not included in the reaction tree to be placed below the reaction tree on the canvas, so that I can view all the data from the RDF file in a structured and organized manner.

Acceptance Criteria:

  1. The application should identify any reactions or elements in the loaded RDF file that are not included in the reaction tree.

  2. Reactants and products without match should be understand as a separate reactions.

  3. These identified reactions or elements should be placed on the canvas below the reaction tree. They should not overlap with the reaction tree or with each other.

  4. Reactions not included to a pathway reaction, should be displayed as separate multi-tail reactions.

    • The case in RDF a+b->c, d+e->f, c+g->h. After loading we will have a pathway for a+b->c, c+g->h and another reaction separately d+e->f
  5. Reactions with more than one product can be a part of pathway reaction if the match happens, they will be displayed without pluses, otherwise reactions will be displayed as separate ones with a multi-tail arrow when we have several reactants and with a single arrow when we have 1 reactant

  6. TBD: Molecule with atoms that are placed on the same position can be loaded as reactants or products in pathway reaction - issues with existing behavior, defects are reported - "Convert error! metalayout: average bond length is too small" error appears when loading from RDF and RXN V2000/V3000 reactions with molecules with 0 coordinates #2431, Molecule with 0 coordinates in MOL V2000 is displayed incorrectly on Canvas after loading #2432

  7. Reagents should be ignored (TBD - create a task for case where reagents can be recognized)

  8. In case of empty RDF (no reactions, reactants or products), nothing should be added to the canvas.

  9. In cases of one reactant or one product in pathway reaction, it should works as for single arrow in RXN

  10. RDF file can be recognized if there are reactions, RDF file with molecules only can't be recognized - error is displayed

  11. After loading from the RDF file, the ordering of separate cascade reactions on Canvas should be the same as in the RDF file


  1. The placement of these reactions or elements should be done in an organized manner, maintaining a clear separation between the reaction tree and the additional reactions or elements.
  2. The user should be able to view and interact with these additional reactions or elements just like any other elements on the canvas.
  3. The application should handle the display of multiple additional reactions or elements, ensuring that all are visible and distinguishable.
@yauhen-karmyzau yauhen-karmyzau added Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Jul 8, 2024
@ivanmaslow ivanmaslow changed the title Position single elements and reaction, not included to a cascade reaction Position single elements and reactions, not included to the first cascade reaction Aug 13, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.24.0-rc.1 milestone Aug 28, 2024
@even1024 even1024 linked a pull request Sep 4, 2024 that will close this issue
7 tasks
@ivanmaslow ivanmaslow added the Test Cases Written Test cases has been written for that issue label Sep 24, 2024
@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 8, 2024

Exploratory testing is completed on RC Remote env:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-04; 18:51:40
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-x86_64-linux-gnu-11.2.1
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)

The feature includes different cases for loading from RDF (single reactions, cascade reactions), checks below are covered, tests are updated:

  • Loading from RDF based on RXN V2000, V3000, examples of files with single and cascade reaction:
    rdf-rxn-v2000-single-reaction-3x1.zip:
    image
    rdf-rxn-v3000-cascade-reaction-2-1-1.zip:
    image
  • Different types/combinations of single and cascade reactions can be loaded from RDF and saved to KET with correct positions:
    image
  • Reagents in RDF in reactions are ignored and not displayed on Canvas on loading;
  • RDF file can't be loaded from Macro mode;
  • Basic functionality is working properly for elements loaded from RDF: Undo/Redo of adding/deletion/movement/copying, Movement, Selection, Deletion (Erase/Clear Canvas), Zoom, Copy/Paste;

Detected and fixed defects:

But there are some failed manual tests based on detected defects and the main scenario should be retested after fixes in the nearest releases 1.25.0-rc.2, 1.26.0-rc.1:

This issue is added to refined backlog and will be fixed later:

Also, some unrelated issues were detected during exploratory testing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@even1024 @AlexeyGirin @ivanmaslow @yauhen-karmyzau and others