Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Margin is not correct for reaction which located after arrow #2292

Closed
AnnaKosol opened this issue Sep 3, 2024 · 3 comments
Closed

Comments

@AnnaKosol
Copy link
Collaborator

Summary
Regarding task #2176 implemented margins and layout

Steps to Reproduce

  1. Change Reaction component margin size in the Settings to 40 px

  2. Bond length in the Settings is 20 px

  3. Add to Canvas
    Margin is not correct for reaction which located after arrow.ket.zip

  4. Click on layout

Expected behavior
Margins from right side and left side of arrow are the same

Actual behavior
Снимок экрана 2024-09-03 в 15 36 47

Environment details:
https://nightly.test.lifescience.opensource.epam.com/KetcherDemo/5365-send-acs-parameters-for-layout-and-convert-backend-functions/index.html
Branches:
Ketcher: 5365-send-acs-parameters-for-layout-and-convert-backend-functions
Indigo: feature/2176-add-acs-style-reaction-layout
MacOs 14.6.1
Chrome Версия 127.0.6533.120 (Официальная сборка), (arm64)

@AnnaKosol
Copy link
Collaborator Author

Verified on https://ci.test.lifescience.opensource.epam.com/5362-sending-acs-parameters-when-requesting-render-to-png-and-svg/feature/2175-acs-style-rendering/20240930-091010/micro/KetcherDemoSA/index.html
Image

with new parameters from frontend

Environment
Ketcher branch 5362-sending-acs-parameters-when-requesting-render-to-png-and-svg
Indigo branch 2175-acs-style-rendering
Ketcher Version 2.25.0-rc.2 Build at 2024-09-30; 09:14:32
Indigo Version 1.25.0-dev.2.7-g6118db71-wasm32-wasm-clang-12.0.0

@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants