Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The reaction with reaction mapping tool is displayed incorrect with ACS Style settings #2501

Closed
AnnaKosol opened this issue Oct 4, 2024 · 4 comments · Fixed by #2560 or #2561
Closed

The reaction with reaction mapping tool is displayed incorrect with ACS Style settings #2501

AnnaKosol opened this issue Oct 4, 2024 · 4 comments · Fixed by #2560 or #2561
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: High Team G
Milestone
Indigo-1.25.0-rc.4

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. add reaction to the Canvas
    The reaction with reaction mapping tool is displayed incorrect.ket.zip
Screenshot 2024-10-04 at 19 22 09
  1. click on ACS Style button in the Settings
  2. click on Apply button
  3. click on Layout

Actual behavior
Screenshot 2024-10-04 at 19 26 34

Expected behavior
the schema is displayed regarding settings and margins
Screenshot 2024-10-04 at 19 27 25

Environment details:
https://ci.test.lifescience.opensource.epam.com/5362-sending-acs-parameters-when-requesting-render-to-png-and-svg/feature/2175-acs-style-rendering/20240930-091010/micro/KetcherDemoSA/index.html

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-30; 09:14:32
  • Indigo Version 1.25.0-dev.2.7-g6118db71-wasm32-wasm-clang-12.0.0
  • MacOs 15
@AnnaKosol AnnaKosol added this to the Indigo-1.25.0-rc.2 milestone Oct 4, 2024
@AlexeyGirin
Copy link
Collaborator

Same reason as for #2458

This was linked to pull requests Oct 17, 2024
#2458 The reaction with catalysts is displayed incorrect with ACS style setting and after layout #2560
Merged
Backmerge: #2458 The reaction with catalysts is displayed incorrect with ACS style setting and after layout #2561
Merged
@Zhirnoff
Copy link
Collaborator

Tested. Bug not fixed.

2024-10-21_19h34_47.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.5]
Indigo version
[Version 1.25.0-rc.3]

@Zhirnoff Zhirnoff reopened this Oct 21, 2024
@Zhirnoff
Copy link
Collaborator

Should be tested after fix on Ketcher side in 2.26.0-rc.6 epam/ketcher#5650

@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.26.0-rc.6 Build at 2024-10-25; 09:57:12
  • Indigo Toolkit Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.59 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: High Team G
Projects
None yet
Milestone
Indigo-1.25.0-rc.4
5 participants
@AlexanderSavelyev @AliaksandrDziarkach @AlexeyGirin @Zhirnoff @AnnaKosol