Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump on uninitialised value #2589

Open
hwelzel opened this issue Oct 30, 2024 · 0 comments
Open

Jump on uninitialised value #2589

hwelzel opened this issue Oct 30, 2024 · 0 comments

Comments

@hwelzel
Copy link

hwelzel commented Oct 30, 2024

Summary
Valgrind warns on jump that depends on uninitialised value.

==1094336== Conditional jump or move depends on uninitialised value(s)
==1094336==    at 0x422CF2F: indigoIterateMatches (src/api/c/indigo/src/indigo_match.cpp:988)

The line above is

if (matcher.tau_params.method != BASIC && matcher.mode == IndigoMoleculeSubstructureMatcher::TAUTOMER)

At first sight it seems that inverting the order of the check would fix it.
I suppose that tau_params is uninitialised if matcher.mode is not TAUTOMER.

Environment details:

  • version 1.24.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant