Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: When Reaction Conditions text field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text #2608

Closed
Zhirnoff opened this issue Nov 5, 2024 · 1 comment · Fixed by #2640
Assignees
Labels
Bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 5, 2024

Steps to Reproduce

  1. Copy and Paste on canvas
$RDFILE 1
$DATM    11/05/24 13:20
$RFMT
$RXN

 -INDIGO- 1105241320

  2  1
$MOL

  -INDIGO-11052413202D

  6  6  0  0  0  0  0  0  0  0999 V2000
   10.2348   -7.2251    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   11.9652   -7.2246    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   11.1016   -6.7250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   11.9652   -8.2255    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   10.2348   -8.2300    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   11.1038   -8.7250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
  3  1  2  0  0  0  0
  1  5  1  0  0  0  0
  5  6  2  0  0  0  0
  6  4  1  0  0  0  0
  4  2  2  0  0  0  0
  2  3  1  0  0  0  0
M  END
$MOL

  -INDIGO-11052413202D

  6  6  0  0  0  0  0  0  0  0999 V2000
   10.1098   -9.5751    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   11.8402   -9.5746    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   10.9766   -9.0750    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   11.8402  -10.5755    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   10.1098  -10.5800    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   10.9788  -11.0750    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
  3  1  2  0  0  0  0
  1  5  1  0  0  0  0
  5  6  2  0  0  0  0
  6  4  1  0  0  0  0
  4  2  2  0  0  0  0
  2  3  1  0  0  0  0
M  END
$MOL

  -INDIGO-11052413202D

  6  6  0  0  0  0  0  0  0  0999 V2000
   14.0348   -8.5251    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   15.7652   -8.5246    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.9016   -8.0250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   15.7652   -9.5255    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.0348   -9.5300    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.9038  -10.0250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
  3  1  2  0  0  0  0
  1  5  1  0  0  0  0
  5  6  2  0  0  0  0
  6  4  1  0  0  0  0
  4  2  2  0  0  0  0
  2  3  1  0  0  0  0
M  END
$DTYPE Name
$DATUM Asderwydfgewsghdjedghdfertsdfg
$DTYPE Reference
$DATUM Not available
$DTYPE Reaction Conditions
$DATUM  

Actual behavior
When 'Reaction Conditions text' field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text

Expected behavior
If the 'Reaction Conditions text' field is empty, either no placeholder should appear on the canvas

Screenshot

2024-11-05_14h24_21

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.7]
Indigo version
[Version 1.27.0-dev.1]

Bug foun while pre-testing: #2559

@Zhirnoff Zhirnoff added Bug Priority: Medium MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Nov 5, 2024
@Zhirnoff Zhirnoff added this to the Indigo-1.26.0-rc.1 (Current) milestone Nov 5, 2024
@even1024 even1024 linked a pull request Nov 18, 2024 that will close this issue
7 tasks
@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Nov 20, 2024

The fix is verified on on CI-CD SA environment with Ketcher-Master, Indigo-2404-ket-to-rdf branches:

  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 09:14:36
  • Indigo Version 1.27.0-dev.1.38-g6c821972-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.70 (Official Build) (64-bit)

No additional new lines are added in this case:
image

@ivanmaslow ivanmaslow changed the title When Reaction Conditions text field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text Preview: When Reaction Conditions text field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants