Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Unexpected additional new lines are added to text object of reaction's name and conditions in case of several rows of text after save/load to/from RDF or Layout actions #2645

Closed
ivanmaslow opened this issue Nov 20, 2024 · 1 comment · Fixed by #2640
Assignees
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Nov 20, 2024

Steps to Reproduce

  1. Add reaction with Multi-Tailed arrow and reaction's name and conditions (31 symbols) to Canvas from RDF:
    text-issue-3.zip
    image
  2. Check the text in text editor:
    image
  3. Save/load to/from RDF or make a Layout action

Actual Result

  • Multi-Tailed Arrow size is increased, additional new lines are added to text object:
    image
    image
  • If user does Save/load to/from RDF or Layout action one more time more lines will be added:
    image
    image

Expected Result

  • Reactions with Multi-Tailed arrow and reaction's name and conditions aren't changed after save/load to/from RDF or Layout actions

Environment details

  • Tested on CI-CD SA environment with Ketcher-Master, Indigo-2404-ket-to-rdf branches;
  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 09:14:36
  • Indigo Version 1.27.0-dev.1.38-g6c821972-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.70 (Official Build) (64-bit)

Notes

@ivanmaslow ivanmaslow added Bug Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Nov 20, 2024
@ivanmaslow
Copy link
Collaborator Author

The fix is successfully verified on aws_ci SA env with Ketcher-master and Indigo-2404-ket-to-rdf branches:

  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 19:58:39;
  • Indigo Version 1.27.0-dev.1.43-gec603913-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.86 (Official Build) (64-bit)

New lines aren't added in both cases after save/load to/from RDF or layout actions:
image
image

New defect is created for the case with not correct wrapping:

@ivanmaslow ivanmaslow changed the title Unexpected additional new lines are added to text object of reaction's name and conditions in case of several rows of text after save/load to/from RDF or Layout actions Preview: Unexpected additional new lines are added to text object of reaction's name and conditions in case of several rows of text after save/load to/from RDF or Layout actions Nov 21, 2024
@even1024 even1024 linked a pull request Nov 22, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants