Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a FG on a FG connected to an atom make overlap instead of replace #2268

Open
Zhirnoff opened this issue Feb 23, 2023 · 1 comment
Open
Assignees
Labels

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 23, 2023

Steps to Reproduce

  1. Open Ketcher
  2. Add Functional Group connected with atom on canvas
  3. Select another Functional Group and add to canvas
  4. Choose 'Selection tool' and drag FG to Functional Group connected with atom and try to connect to FG
  5. Choose 'Selection tool' and drag FG to Functional Group connected with atom and try to connect to atom

Actual behavior

  1. Connection to Functional Group: FG overlap FG
  2. Connection to atom: Two functional groups are formed after connection to atom. Sometimes four
    Note: Pay attention to the highlight of the atoms and bond - they start to glow when the FG is just brought up to them

Expected behavior

  1. Connection to Functional Group: FG replace FG
  2. Connection to atom: FG replace atom
    Note: Pay attention to the highlight of the atoms and bond - they start to glow when the FG is just brought up to them

Screenshots

2023-02-23_19h52_52.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.4

@Zhirnoff Zhirnoff added the bug label Feb 23, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.9.0-rc.1 milestone Feb 23, 2023
@Konstantin1996 Konstantin1996 self-assigned this Feb 24, 2023
@yuleicul
Copy link
Collaborator

yuleicul commented Mar 7, 2023

A note: merging behaviors are different after several undo. See: #2302

@Zhirnoff Zhirnoff changed the title Dragging a FG on a FG connected to an atom working incorrect Dragging a FG on a FG connected to an atom make overlap instead of replace Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants