Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete and Backspace hotkeys deletes elements under mouse cursor (hover), but not selected ones #4309

Open
AlexeyGirin opened this issue Mar 21, 2024 · 3 comments
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Mar 21, 2024

Steps to Reproduce

  1. Put on the canvas following SMILES: CCCCCCCCCCCCCCCCCCCCCCC
  2. Select bunch of atoms in the center
    image
  3. Hover mouse cursor over selected atom
  4. Press Del button

Actual behavior
System remove atom under mouse cursor.
Since that moment - pressing DEL button causes nothing
image

Expected behavior
System removes all selected atoms
image

Ketcher version [e.g. v2.4.2].

@AlexeyGirin AlexeyGirin added this to the Waiting for triage milestone Mar 21, 2024
@AlexeyGirin AlexeyGirin added the Micromolecules canvas Bucket: Micromolecules canvas related issues label Apr 25, 2024
@ivanmaslow ivanmaslow changed the title Del key deletes atom under mouse custor but not a selected ones Delete and Backspace hotkeys deletes elements under mouse cursor (hover), but not selected ones Sep 4, 2024
@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 4, 2024

The issue is reproducible for all types of elements and it causes multiple problems when trying to delete selected elements using hotkeys (delete or backspace) and when the cursor is on other elements, also there are issues with undo of deletion:

chrome_DLYGfVkDsL.mp4

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 5, 2024

The bug has been moved to 2.26 after discussions with the MMPK team and @vanoprenko

@ivanmaslow
Copy link
Collaborator

Also, please, take a look at the scenario below during the implementation of the fix, perhaps it's related to this issue, if not - please create an additional task:

  1. Add two elements to Canvas (e.g.: arrow and benzene ring):
    image
  2. Select the first one (e.g.: arrow);
  3. Click on Ctrl+C and hold
  4. Hover on another element - the whole benzene ring is selected:
    image
  5. When you hovering, click on Ctrl+V, add an arrow to Canvas - hovering for the whole element is still displayed:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Projects
None yet
Development

No branches or pull requests

4 participants