Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: Introduce IDT alias for monomers and RNA presets in library and Ketcher model #4310

Closed
rrodionov91 opened this issue Mar 21, 2024 · 3 comments · Fixed by #4515
Closed
Assignees
Labels
feature request IDT Bucket: IDT related issues Monomer Library Test Cases Written Test cases has been written for that issue

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Mar 21, 2024

Background
To support IDT format import/export it needs to add some relations between monomers in Ketcher library and IDT library.

Solution
It needs to introduce IDT alias field to monomer and rna templates in ketcher library according to ket specification.
IDT alias should be also stored in monomer model to have an access to it during the export/import in future.
One monomer or RNA preset could have multiple IDT aliases.

Examples:
List of monomers/rna presets for which IDT alias should be added in library:
image
image
image

Ket files - TBD

@rrodionov91 rrodionov91 added this to the Ketcher 2.22.0-rc.1 milestone Mar 21, 2024
@olganaz olganaz changed the title Macro: Introduce IDT alias for monomers and rna presets in library and Ketcher model Macro: Introduce IDT alias for monomers and RNA presets in library and Ketcher model Mar 22, 2024
@olganaz olganaz added Monomer Library IDT Bucket: IDT related issues labels Apr 5, 2024
@rrodionov91 rrodionov91 self-assigned this Apr 23, 2024
@rrodionov91 rrodionov91 linked a pull request Apr 24, 2024 that will close this issue
9 tasks
@AlexeyGirin
Copy link
Collaborator

Test cases are not needed for this particular issue

@NadezhdaPeskun
Copy link

Is not implemented fully. Should be verified after fix of the next bugs:

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 4, 2024

Tested.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request IDT Bucket: IDT related issues Monomer Library Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants