Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous attachment points selection logic #4613

Closed
AlexeyGirin opened this issue May 13, 2024 · 1 comment
Closed

Ambiguous attachment points selection logic #4613

AlexeyGirin opened this issue May 13, 2024 · 1 comment
Labels
Macro-Micro Bucket: Macro-Micro View related issues

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented May 13, 2024

This is follow up for #4530

Background
User is able to create molecules (in micro mode) that contains same leaving groups (Rx) for different atoms but same molecule
At that case we have to introduce rule(s) of selection - which attachment point to use in case of bond operation
image

Solution
Rule: Simply took first valid attachment point for connection. In example above - R7 number 1 and number 3 are valid APs for connection. So one of them should be selected.

@AlexeyGirin AlexeyGirin added feature request Macro-Micro Bucket: Macro-Micro View related issues labels May 13, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.1 milestone May 13, 2024
@rrodionov91
Copy link
Collaborator

Requirements of initial task changed #4530.
Issue describes impossible scenario in current application state.
Closing as not planned

@rrodionov91 rrodionov91 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
@AlexeyGirin AlexeyGirin removed this from the Ketcher 2.22.0-rc.2 milestone Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Macro-Micro Bucket: Macro-Micro View related issues
Projects
Status: Done
Development

No branches or pull requests

2 participants