Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo/Redo operation doesn't work if you delete anything with attachment point from molecule with attachment point #4803

Closed
AlexeyGirin opened this issue Jun 6, 2024 · 2 comments
Closed

Undo/Redo operation doesn't work if you delete anything with attachment point from molecule with attachment point #4803

AlexeyGirin opened this issue Jun 6, 2024 · 2 comments
Assignees
@Guch1g0v
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Milestone
Ketcher 2.23.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Load from file: Undo Redo doesn't work for attachment points.zip
    OR manually create following configuration on the canvas save it to KET, reload Ketcher and load file back:
    image
  2. Select Erase tool
    image
  3. Select few atoms with attachment points having Erase tool selected
    Entire molecule disappears - not good
  4. Press Undo button

Actual behavior
Another molecule disappears and canvas become empty
image

Expected behavior
Deleted elements returned back
image

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530
@AlexeyGirin AlexeyGirin added bug Priority: Medium Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 6, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 6, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 13, 2024
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Jun 17, 2024 •
edited
Loading

Not reproduced any more.
image

Kercher Version 2.22.0-rc.6
Indigo Version 1.21.0-rc.1.0-g9194599b2-x86_64-linux-gnu-11.2.1
Win10
Chrome 126.0.6478.62 (Official Build) (64-bit)

@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Projects
None yet
Milestone
Ketcher 2.23.0-rc.1
Development

No branches or pull requests
2 participants
@AlexeyGirin @Guch1g0v