Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Abbreviation dialog rises if we first select attachment point and then click on atom in atom toolbar #4969

Closed
Zhirnoff opened this issue Jul 3, 2024 · 2 comments · Fixed by #4967 or #5019
Closed

Edit Abbreviation dialog rises if we first select attachment point and then click on atom in atom toolbar #4969

Zhirnoff opened this issue Jul 3, 2024 · 2 comments · Fixed by #4967 or #5019
Assignees
@Guch1g0v
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Low
Milestone
Ketcher 2.23.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 3, 2024

Steps to Reproduce

  1. Load from file: It is impossible to apply R-group to atom with attachment point attached.zip
    OR manually create following configuration on the canvas:
    image
  2. With Rectangle selection select attachment point
  3. Click on any atom in atom toolbar

Actual behavior
Edit Abbreviation dialog rises if we first select attachment point and then click on atom in atom toolbar

Expected behavior
The system shouldn't open the Edit Abbreviation dialog. The attachment point should not change to an atom.

Video

2024-07-03_10h00_08.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.1]
Indigo version
[Version 1.22.0-rc.1]

Bug found while testing: #4776
Requirements: #4530
@Zhirnoff Zhirnoff added bug Priority: Low Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jul 3, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.23.0-rc.2 milestone Jul 3, 2024
This was referenced Jul 3, 2024
Closed
Closed
@Guch1g0v Guch1g0v self-assigned this Jul 3, 2024
@Guch1g0v Guch1g0v linked a pull request Jul 3, 2024 that will close this issue
#4927 - Able to change attachment point label to an atom if it is selected first #4967
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jul 3, 2024

Moved to 2.23.0-rc.2 after discussion with developer @Guch1g0v because he has a pull request ready

@Guch1g0v Guch1g0v linked a pull request Jul 5, 2024 that will close this issue
Backmerge: #4927 - Able to change attachment point label to an atom if it is selected first #5019
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-07-11_15h05_27.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.2]
Indigo version
[Version 1.22.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Low
Projects
None yet
Milestone
Ketcher 2.23.0-rc.2
2 participants
@Zhirnoff @Guch1g0v