Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaded images change level layers after Undo/Redo #5118

Closed
ivanmaslow opened this issue Jul 16, 2024 · 2 comments
Closed

Loaded images change level layers after Undo/Redo #5118

ivanmaslow opened this issue Jul 16, 2024 · 2 comments
Assignees
Labels
bug Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Jul 16, 2024

Steps to Reproduce

  1. Load images from .ket file and add to Canvas:
    images-png-svg.zip
    image
  2. Click on Undo - loaded images disappear
  3. Click on Redo

Actual behavior
Layer levels of Images are reversed
image

Expected behavior
Layer levels of Images are the initial
image

Desktop:

  • OS: Windows 11 Enterprise
  • Browser: Chrome 126.0.6478.127 (Official Build) (64-bit)

Ketcher version [2.23.0-rc.1 Build at 2024-07-16; 10:35:24] - nightly: 4902-image-selection-and-movement

Additional Context:

  • Issue can be also reproduced using 'Add Image":
  1. Add two images with overlapping - the second is on top layer
  2. Delete the first one
  3. Delete the second one
  4. Make redo to see the both images - the first is on top layer (the second should be on top layer)
@ivanmaslow ivanmaslow added bug Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Jul 16, 2024
@ivanmaslow ivanmaslow changed the title Loaded images change level layers after Undo/Redo: Preview: Loaded images change level layers after Undo/Redo: Jul 16, 2024
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Jul 16, 2024

Discussed with DM - no plans to fix in 2.24.0-rc.1, added to Refined Backlog

@ivanmaslow ivanmaslow changed the title Preview: Loaded images change level layers after Undo/Redo: Preview: Loaded images change level layers after Undo/Redo Aug 1, 2024
@ivanmaslow ivanmaslow changed the title Preview: Loaded images change level layers after Undo/Redo Loaded images change level layers after Undo/Redo Aug 14, 2024
@ivanmaslow ivanmaslow added this to the Backlog milestone Sep 3, 2024
@yauhen-karmyzau
Copy link
Collaborator

This issue requires huge changes in canvas items rendering and can affect other functionality. Project backlog already has a feature to change rendering engine and this defect will be fixed in scope of such refactoring.

@yauhen-karmyzau yauhen-karmyzau closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
Development

No branches or pull requests

3 participants