Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System merge sequences while replacing selected monomers from the library in edit mode #5234

Closed
AlexeyGirin opened this issue Aug 7, 2024 · 1 comment · Fixed by #5259 or #5271
Closed
Assignees
Labels

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 7, 2024

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode

  2. Load from file: System allow to change monomers on the canvase in view mode (that is not allowed).zip
    image

  3. Switch canvas to text-edit mode

  4. Select some monomers
    image

  5. Go to Library - Peptides tab

  6. Click on D peptide

Actual behavior
All selected monomers changed to D peptide and all sequences merged to one
image

Expected behavior
All selected monomers changed to D peptide and sequences remain in place
As per requirement:

  1. If the user selects any number of monomers in text-editing mode, and clicks on the monomer card in the library, one chosen monomer form the library should replace all the selected monomer(s) on the canvas. (user selects 5 monomers -> user selects A in the library -> 5 monomers get replaced by 1 A)

image

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878

@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment