Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo of replacing all DNAs in sequence in view mode on preser (C) from the library causes undeletable monomer on the canvas (all of them) #5250

Closed
AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5259 or #5271
Closed

Undo of replacing all DNAs in sequence in view mode on preser (C) from the library causes undeletable monomer on the canvas (all of them) #5250

AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5259 or #5271
Assignees
@rrodionov91
Labels
bug Monomer Library Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.24.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Load from file: Replacing all DNAs in sequence in view mode from the library causes undeletable monomer on the canvas (all of them).zip
    image
  3. Select all monomers (in view mode)
    image
  4. Go to Library - RNA tab - Presets
  5. Click on C preset
    image
  6. Press Undo button

Actual behavior
@ symbol remains one the canvas
image
If you switch to flex mode - you found corrupted canvas
image

Expected behavior
Canvas returned back to initial state
image

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.2 milestone Aug 8, 2024
@AlexeyGirin AlexeyGirin changed the title Replacing all DNAs in sequence in view mode from the library causes undeletable monomer on the canvas (all of them) Undo of replacing all DNAs in sequence in view mode from the library causes undeletable monomer on the canvas (all of them) Aug 8, 2024
@AlexeyGirin AlexeyGirin changed the title Undo of replacing all DNAs in sequence in view mode from the library causes undeletable monomer on the canvas (all of them) Undo of replacing all DNAs in sequence in view mode on preser (C) from the library causes undeletable monomer on the canvas (all of them) Aug 8, 2024
@rrodionov91 rrodionov91 self-assigned this Aug 8, 2024
This was linked to pull requests Aug 8, 2024
Backmerge: #5242 - Replace phosphate at the end with petide causes cycled polymer #5259
Merged
#5242 - Replace phosphate at the end with petide causes cycled polymer #5271
Merged
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Monomer Library Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.24.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin