Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydrogens are not shown for single atoms in Macro mode (and for atom in bonds too) #5675

Closed
AlexeyGirin opened this issue Oct 7, 2024 · 2 comments
Closed

Hydrogens are not shown for single atoms in Macro mode (and for atom in bonds too) #5675

AlexeyGirin opened this issue Oct 7, 2024 · 2 comments
Assignees
@rrodionov91
Labels
bug Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: Medium
Milestone
Ketcher 2.28.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 7, 2024 •
edited
Loading

Steps to Reproduce

  1. Put on Micro molecules canvas simple atoms (Li and C in my case)
    image
  2. Switch to Macro mode

Actual behavior
Hydrogens are not shown for single atoms in Macro mode
image

Expected behavior
Hydrogens should be shown
image

As per requirements:

Hydrogen label should be placed after/before atom label with number subscript which in case if atom has valence more than connections.

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Issue found while testing: #5359
@AlexeyGirin AlexeyGirin added bug Priority: Medium Micro-Macro Bucket: Bugs related to Micro structures on Macro mode labels Oct 7, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.27.0-rc.1 milestone Oct 7, 2024
@AlexeyGirin AlexeyGirin changed the title Hydrogens are not shown for single atoms in Macro mode Hydrogens are not shown for single atoms in Macro mode (and for atom in bonds too) Nov 5, 2024
@rrodionov91 rrodionov91 self-assigned this Nov 27, 2024
@rrodionov91
Copy link
Collaborator

Fixed

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 6, 2024

Tested. Bug fixed.

2024-12-06_18h32_16

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.1]
Indigo version
[Version 1.27.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: Medium
Projects
None yet
Milestone
Ketcher 2.28.0-rc.1
Development

No branches or pull requests
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff