-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide dist/underscore.string.min.js
in the npm package (again)
#402
Conversation
This is okay for me. |
Yes. I also think the both |
@Mithgol could you remove |
Yep. |
Could you drop the first unused commit? Thanks |
Ok. |
provide `dist/underscore.string.min.js` in the npm package (again)
Thanks 💯 |
Could you |
I will tomorrow. 😄 |
@Mithgol 3.0.3 is released. |
Browser window's context and Node.js context are different in nw.js and it takes some time to switch between them.
Therefore, when
underscore.string
is used inside an nwjs-based application, it sometimes makes sense to do both of the following:underscore.string
as a dependency inpackage.json
(example) and let it be installed withnpm install
underscore.string
in a browser's window context with<script>
(example) instead of (or in addition to) Node.js context withrequire()
.However, the npm package of
underscore.string
does not currently contain thedist/underscore.string.min.js
file that could be installed and referenced by thescript
element.That's why this pull request partially reverts c3088d4 (and #193): the minified file
dist/underscore.string.min.js
is re-added to the npm package. (The larger filedist/underscore.string.js
continues to be removed from the package.)