Add flag to capitalize to lowercase remaining characters #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,7 @@ $(document).ready(function() { | |||
| equal(_('fabio').capitalize(), 'Fabio', 'First letter is upper case'); | |||
| equal(_.capitalize('fabio'), 'Fabio', 'First letter is upper case'); | |||
| equal(_.capitalize('FOO'), 'FOO', 'Other letters unchanged'); | |||
| equal(_.capitalize('FOO', true), 'Foo', 'Other letters are lowercased'); | |||
There was a problem hiding this comment.
could you add some more test i.e
equal(_.capitalize('foO', true), 'Foo', 'Other letters are lowercased');
// and maybe some tests with lowercaseRest explicit "false"
|
Could you squash your commits to one? Would be nice, thanks. |
|
All of them? Because the Contributing document mentions providing separate commits with tests. |
|
Yes, I would make one commit it's not really a bug. One commit would be cool. |
stoeffel
added a commit
that referenced
this pull request
Feb 17, 2015
Add flag to capitalize to lowercase remaining characters
|
👍 |
|
😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag to capitalize that when set to
truewill convert all characters after the first one to lowercase. Example: