Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove installGlobals calls #802

Closed
kinggoesgaming opened this issue Jul 21, 2024 · 3 comments · Fixed by #803
Closed

Remove installGlobals calls #802

kinggoesgaming opened this issue Jul 21, 2024 · 3 comments · Fixed by #803

Comments

@kinggoesgaming
Copy link
Contributor

The globals added by installGlobals are now natively available with node 20+

Ref: remix-run/remix#7067 (comment)
@kinggoesgaming
Copy link
Contributor Author

Ok I think I might have misunderstood that comment. Need a second opinion before I anything here

@kinggoesgaming
Copy link
Contributor Author

Ok I think I might have misunderstood that comment. Need a second opinion before I anything here

Looking further.. I am correct on the fact that installGlobals is no longer needed

@kentcdodds
Copy link
Member

Yeah, we can remove that I think

This was referenced Jul 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kentcdodds @kinggoesgaming