feat: Consider content from before and after pseudo elements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
pushed a commit
that referenced
this pull request
Nov 5, 2019
# [0.1.0](v0.0.1...v0.1.0) (2019-11-05) ### Bug Fixes * Fix test name_heading-combobox ([#16](#16)) ([e969395](e969395)) ### Features * **name:** Consider prohibited naming ([#19](#19)) ([6692d6b](6692d6b)) * Consider all cases of "name from content" ([#13](#13)) ([835cb76](835cb76)) * Consider content from before and after pseudo elements ([#5](#5)) ([0987426](0987426)) * Fork elementToRole from aria-query ([#7](#7)) ([fe4fab5](fe4fab5))
valzhad
pushed a commit
to valzhad/dom-accessibility-api
that referenced
this pull request
Mar 27, 2023
# [0.1.0](eps1lon/dom-accessibility-api@v0.0.1...v0.1.0) (2019-11-05) ### Bug Fixes * Fix test name_heading-combobox ([#16](eps1lon/dom-accessibility-api#16)) ([e969395](eps1lon/dom-accessibility-api@e969395)) ### Features * **name:** Consider prohibited naming ([#19](eps1lon/dom-accessibility-api#19)) ([6692d6b](eps1lon/dom-accessibility-api@6692d6b)) * Consider all cases of "name from content" ([#13](eps1lon/dom-accessibility-api#13)) ([835cb76](eps1lon/dom-accessibility-api@835cb76)) * Consider content from before and after pseudo elements ([#5](eps1lon/dom-accessibility-api#5)) ([0987426](eps1lon/dom-accessibility-api@0987426)) * Fork elementToRole from aria-query ([#7](eps1lon/dom-accessibility-api#7)) ([fe4fab5](eps1lon/dom-accessibility-api@fe4fab5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supported in browser. jsdom does not support before/after in getComputedStyle
name_test_case_659-manualandname_test_case_660-manualare not following spec IMO.Some passes are due to concatenating content with whitespace which violates the spec.