Skip to content

Commit d06285d

Browse files
zhewenlsimon-mo
authored andcommitted
[CI/Build] Also check DP in benchmarks throughput script (vllm-project#23038)
Co-authored-by: Simon Mo <simon.mo@hey.com>
1 parent d64cc73 commit d06285d

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

benchmarks/benchmark_throughput.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -597,8 +597,8 @@ def validate_args(args):
597597
# https://github.com/vllm-project/vllm/issues/16222
598598
if args.data_parallel_size > 1:
599599
raise ValueError(
600-
"Data parallel is not supported in offline benchmark, \
601-
please use benchmark serving instead"
600+
"Data parallel is not supported in offline benchmark, "
601+
"please use benchmark serving instead"
602602
)
603603

604604

vllm/benchmarks/throughput.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,14 @@ def validate_args(args):
434434
if args.backend == "mii" and args.tokenizer != args.model:
435435
raise ValueError(
436436
"Tokenizer must be the same as the model for MII backend.")
437+
438+
# --data-parallel is not supported currently.
439+
# https://github.com/vllm-project/vllm/issues/16222
440+
if args.data_parallel_size > 1:
441+
raise ValueError(
442+
"Data parallel is not supported in offline benchmark, "
443+
"please use benchmark serving instead"
444+
)
437445

438446

439447
def add_cli_args(parser: argparse.ArgumentParser):

0 commit comments

Comments
 (0)