Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove config & defaults globals #176

Closed
tobert opened this issue Mar 15, 2023 · 3 comments
Closed

remove config & defaults globals #176

tobert opened this issue Mar 15, 2023 · 3 comments
Labels
code quality Issues & opportunities to improve code quality and maintainability patch patch semver

Comments

@tobert
Copy link
Collaborator

tobert commented Mar 15, 2023

In the first release of otel-cli, configuration was a bunch of globals in the cmd package. This later was moved into the Config struct, replacing global vars with global config.Field. Now that Config is settled down and in good shape, it's time to clean up the config and defaults globals to instead pass around data.

This will require a few changes to function signatures to pass Config around. Some unit tests may change too, and some cleaner unit testing options will become available when it's done.

@tobert tobert added patch patch semver code quality Issues & opportunities to improve code quality and maintainability labels Mar 15, 2023
@tobert
Copy link
Collaborator Author

tobert commented May 12, 2023

Made some progress on this in #198

@tobert
Copy link
Collaborator Author

tobert commented Jun 26, 2023

config global is gone. only otlpclient.Diag remains, will be gone soon

@tobert
Copy link
Collaborator Author

tobert commented Mar 11, 2024

For the most part, the config global is gone. Diag remains and will be iterated out over time, but it's so low risk and high utility it might not matter.

@tobert tobert closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Issues & opportunities to improve code quality and maintainability patch patch semver
Projects
None yet
Development

No branches or pull requests

1 participant