You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the first release of otel-cli, configuration was a bunch of globals in the cmd package. This later was moved into the Config struct, replacing global vars with global config.Field. Now that Config is settled down and in good shape, it's time to clean up the config and defaults globals to instead pass around data.
This will require a few changes to function signatures to pass Config around. Some unit tests may change too, and some cleaner unit testing options will become available when it's done.
The text was updated successfully, but these errors were encountered:
For the most part, the config global is gone. Diag remains and will be iterated out over time, but it's so low risk and high utility it might not matter.
In the first release of otel-cli, configuration was a bunch of globals in the
cmd
package. This later was moved into theConfig
struct, replacing global vars with globalconfig.Field
. Now that Config is settled down and in good shape, it's time to clean up theconfig
anddefaults
globals to instead pass around data.This will require a few changes to function signatures to pass
Config
around. Some unit tests may change too, and some cleaner unit testing options will become available when it's done.The text was updated successfully, but these errors were encountered: