Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a node_pools variable to this module #92

Open
displague opened this issue Sep 30, 2021 · 0 comments
Open

introduce a node_pools variable to this module #92

displague opened this issue Sep 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@displague
Copy link
Member

displague commented Sep 30, 2021

https://github.com/equinix/terraform-metal-multiarch-k8s/blob/main/kubernetes-node-pool.tf could be implemented as a for loop over a var.node_pools slice of structs.

The existing hard-coded green/blue node pools would be replaced with user-defined sets of node pools where all options can be specified.

Variables that look like count_arm = 1; plan_arm = "foo" would become node_pools = [{name: "arm", count=1, instance_type: "foo"}].

In order to get this benefit, we may need to combine gpu_node_pool module options and customizations into the node_pool module.

node_pool/modules/gpu/main.tf ()
node_pool/variables.tf gpu_node_options = { install_foo: true, ...}

It may not be necessary to create a gpu module if there are no resources unique to this configuration. In that case, we can conditionally overlay all gpu options in the node_pool module.

@displague displague added the enhancement New feature or request label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant